[prophet-report] PreferTypeMethodOverInlineDispatch: False positive: this match($this) IS the type-method the rule asks for — toke…

[jessegall]

Reported automatically by a code-commandments agent.

Prophet	PreferTypeMethodOverInlineDispatch
Location	src/Pipeline/Execution/WireCategory.php:32

What's wrong

False positive: this match($this) IS the type-method the rule asks for — token() already lives ON WireCategory and dispatches on its own cases. The rule's prescribed fix ('give self a method, call $this->method()') is literally this code; a per-case enum method's body must be a match($this). There is no outer type to move behaviour onto.

Flagged code

return match ($this)

For the fixer

Decide whether this is a false positive (tighten/guard the prophet), a wrong rule (adjust the rule or its config), or correct-but-unclear (improve the message/scripture). Add a fixture from the flagged code above.

[jessegall]

Fixed in v1.61.1.

Confirmed false positive. WireCategory::token() is return match ($this) { self::Mixed => …, … } — a per-case method on the enum itself, which is exactly the fix the rule prescribes. The own-file skip already handled match ($this) { WireCategory::Mixed => … } (arms resolve to the enum's FQCN), but self::Mixed arms resolve to a self pseudo-FQCN, so they slipped past and the destination got flagged as the smell.

Fix: the skip now also matches self::/static:: dispatch that lives inside an enum (those always refer to the enclosing enum). Added a fixture with self:: cases.

Bump to ^1.61.1.