[prophet-report] SuggestCompareSelfTraitProphet: Prophet/PHPStan conflict: the rule now MANDATES the case-anchored instance fo…

[jessegall]

Reported automatically by a code-commandments agent.

Prophet	SuggestCompareSelfTraitProphet
Location	src/Support/Enums/CompareSelf.php

What's wrong

Prophet/PHPStan conflict: the rule now MANDATES the case-anchored instance form Enum::Case->equals($x) (static Enum::equals($x, Case) against a literal case is a sin). But that instance call does NOT type-check at PHPStan max level: PHPStan resolves NodeType::Control->equals($x) against the trait's STATIC @method static bool equals(mixed $value, self $case) (2 required) rather than the instance @method bool equals(mixed $value), producing 'Method NodeType::equals() invoked with 1 parameter, 2 required' (arguments.count) + argument.type errors on EVERY case-anchored call repo-wide (~69). The two same-named @method declarations (instance + static) on CompareSelf are ambiguous to PHPStan when the receiver is an enum case. Either the generated CompareSelf trait needs PHPStan-resolvable annotations (or real methods) for the dual instance/static API, or the prophet should not mandate a form that fails the type checker.

For the fixer

Decide whether this is a false positive (tighten/guard the prophet), a wrong rule (adjust the rule or its config), or correct-but-unclear (improve the message/scripture). Add a fixture from the flagged code above.

[jessegall]

Fixed in v1.56.2.

Root cause: the scaffolded CompareSelf trait declared the singular helper both ways —

@method bool equals(mixed $value)                     // instance, 1 arg
@method static bool equals(mixed $value, self $case)  // static, 2 args

For a Class::Case->equals($x) access PHPStan resolves to the static 2-arg signature → invoked with 1 parameter, 2 required on every anchored call.

Fix: the singular equals/notEquals (+IgnoreType) family is now declared instance-only, so the case-arrow call resolves to the 1-arg instance signature and type-checks. Since a static Enum::equals($x, Enum::Case) against a known case is already a sin, dropping its @method static makes PHPStan and the prophet agree — both reject the static-singular form, both accept the anchored instance form. The *Any set helpers stay static (never case-anchored, no ambiguity). Runtime is unchanged — __call/__callStatic still forward every shape. Added a scaffold regression test (test_compare_self_declares_singular_helpers_instance_only).

To pick up the fix: bump to ^1.56.2 and re-scaffold the trait (commandments scaffold --force, or it regenerates on sync).

One edge note: a genuinely dynamic-vs-dynamic Enum::equals($a, $b) (neither operand a literal case) is no longer type-blessed either. That form is rare; prefer $a === $b for two enum instances, or anchor on whichever side is a known case.