[prophet-report] SuggestCompareSelfTraitProphet: Residual of the equals/instance fix (1.58.1): the VARIADIC helpers equalsAny/…

[jessegall]

Reported automatically by a code-commandments agent.

Prophet	SuggestCompareSelfTraitProphet
Location	src/Workflow/Graph/GraphValidator.php:266

What's wrong

Residual of the equals/instance fix (1.58.1): the VARIADIC helpers equalsAny/notEqualsAny still fail PHPStan. Both instance $kind->equalsAny(NodeType::Trigger, NodeType::Input) and static NodeType::equalsAny($x, A, B) report 'Parameter #2 ...$cases expects JesseGall\Workflows\Support\Enums\CompareSelf, NodeType::Input given'. The trait's @method ...$cases (typed self) resolves self to the CompareSelf trait rather than the using enum, so passing real enum cases is rejected. equals()/notEquals() were fixed but equalsAny()/notEqualsAny() have the same self-binding problem. Affects every multi-case comparison the prophet mandates (e.g. NodeType, MathOperator, WorkflowRunStatus).

Flagged code

if (! $descriptor->kind->equalsAny(NodeType::Trigger, NodeType::Input))

For the fixer

Decide whether this is a false positive (tighten/guard the prophet), a wrong rule (adjust the rule or its config), or correct-but-unclear (improve the message/scripture). Add a fixture from the flagged code above.

[jessegall]

Fixed in v1.58.2.

Confirmed — residual of #6 for the variadic helpers. Two failures, one fix:

1. The same instance/static @method ambiguity resolved $kind->equalsAny(...) (an instance call) to the static signature;
2. self in a trait @method binds to the trait (CompareSelf), not the using enum, so the static self ...$cases rejected the real enum cases passed.

Fix: the variadic case parameters are now typed \\UnitEnum instead of self. \\UnitEnum accepts any enum case, so both the static form and the (mis-resolved) instance call type-check regardless of which @method PHPStan picks. Singular equals/notEquals were already instance-only from #6; only the *Any family needed this. Scaffold regression test updated.

Bump to ^1.58.2 and re-scaffold (auto on sync) to regenerate the trait.