[prophet-report] ExplicitDataFactory: Marked [AUTO-FIXABLE] but 'repent --git' reports 'No changes made' for every …

[jessegall]

Reported automatically by a code-commandments agent.

Prophet	ExplicitDataFactory
Location	src/Http/Data/NodeSocketData.php:58

What's wrong

Marked [AUTO-FIXABLE] but 'repent --git' reports 'No changes made' for every ExplicitDataFactory finding (NodeSocketData, WorkflowDetailData, SocketEffect, UnpackRegistry, two tests) — the autofix is a no-op, so the sin cannot be cleared mechanically as the label promises.

Flagged code

return new self(

For the fixer

Decide whether this is a false positive (tighten/guard the prophet), a wrong rule (adjust the rule or its config), or correct-but-unclear (improve the message/scripture). Add a fixture from the flagged code above.

[jessegall]

Fixed in v1.60.1.

Confirmed — a presentation bug, not a detection one. ExplicitDataFactory emits a mix: empty_from / new_default are mechanical (repent rewrites to ::make()), but new_mapping (new self(field: …), hand hydration), nonarray, and toarray_outside need a human-written factory. The prophet already sets each finding's autoFixable correctly (false for those), and the message text never claims AUTO-FIXABLE for them.

The bug: both judge --next and the sins summary recomputed the [AUTO-FIXABLE] label from $prophet instanceof SinRepenter (prophet-level), ignoring the per-finding flag — so a new self(field: …) sin got labelled fixable and repent --git no-op'd.

Fix: --next now uses $finding->autoFixable (already resolved as $sin->autoFixable ?? prophet-level); the summary labels a prophet [AUTO-FIXABLE] only when at least one of its findings actually is. So an all-new_mapping ExplicitDataFactory run no longer promises a mechanical fix — those are hand-fixed (hydrate through static::from(array)). Fixed in both the standalone and artisan commands; added regression tests asserting the per-finding flag.

Bump to ^1.60.1.