Watch misclassifies generated pod log methods

[tamird]

/kind bug

Kubernetes 36.0.2 generates the read_namespaced_pod_log parameter
documentation as:

:param follow: Follow the log stream of the pod.
:type follow: bool

Watch.get_watch_argument_name still looks for the older
:param bool follow: form. It therefore classifies this as a resource watch
and injects watch=True instead of follow=True. The generated client then
raises ApiTypeError because watch is not accepted by the pod log method.

The existing test_watch_for_follow fixture also uses the obsolete docstring
shape, so it does not catch the regression.

[kubernetes-prow]

@tamird: The label(s) kind/bug\n\nkubernetes, kind/36.0.2, kind/generates, kind/the, kind/, kind/parameter\ndocumentation, kind/as:\n\n\n\n, kind/still, kind/looks, kind/for, kind/the, kind/older\n, kind/form., kind/it, kind/therefore, kind/classifies, kind/this, kind/as, kind/a, kind/resource, kind/watch\nand, kind/injects, kind/, kind/instead, kind/of, kind/., kind/the, kind/generated, kind/client, kind/then\nraises, kind/, kind/because, kind/, kind/is, kind/not, kind/accepted, kind/by, kind/the, kind/pod, kind/log, kind/method.\n\nthe, kind/existing, kind/, kind/fixture, kind/also, kind/uses, kind/the, kind/obsolete, kind/docstring\nshape,, kind/so, kind/it, kind/does, kind/not, kind/catch, kind/the, kind/regression. cannot be applied, because the repository doesn't have them.

Details

In response to this:

/kind bug\n\nKubernetes 36.0.2 generates the parameter\ndocumentation as:\n\n\n\n still looks for the older\n form. It therefore classifies this as a resource watch\nand injects instead of . The generated client then\nraises because is not accepted by the pod log method.\n\nThe existing fixture also uses the obsolete docstring\nshape, so it does not catch the regression.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.