Add 'claude' provider alias, tighten CLI URL parsing, and improve start/send concurrency safety#1
Open
Add 'claude' provider alias, tighten CLI URL parsing, and improve start/send concurrency safety#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
claudeas a provider alias and normalizing it toanthropicacross languages.Session.Sendso concurrent starts and context cancellation behave correctly.Description
docs/integrations/claude-code-compatibility.mdand linked it fromdocs/index.mdto document Claude/Anthropic compatibility.provider.type = "claude"->"anthropic"in Go (normalizeProviderConfig), Node (normalizeProviderConfig), and Python (_convert_provider_to_wire_format) and extended provider types to includeclaudein Go/Node/Python type definitions.parseCliUrl), Node (parseCliUrl), and Python (_parse_cli_url) to trim input, accept bare port numbers, prependhttp://for parsing, validate port ranges, and raise descriptive errors for invalid formats.Session.Sendrespect context cancellation by performing the RPC in a goroutine and selecting onctx.Done(); updatedSendAndWaitto propagate context errors.startPromise) and Python (_start_taskwith_start_lock) so multiple simultaneousstart()calls reuse a single startup flow.Testing
go test ./...and the Go build which completed successfully.npm test/tscand integration smoke flows which succeeded.pytestand basic runtime checks including type checks which passed.Codex Task