Harden fork PR auto-close workflow and align contributor guidance#14
Harden fork PR auto-close workflow and align contributor guidance#14marilene38 with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: marilene38 <135267736+marilene38@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR tightens the repository’s fork PR auto-closure behavior and aligns contributor-facing messaging by linking to a stable “Contributing Feedback” section in the README.
Changes:
- Updates the auto-close workflow to also run on
pull_request_target.synchronize, simplifies gating via a job-levelif, and removes theauthor_associationrestriction. - Extends the auto-close comment with a direct link to the repository’s contribution/feedback policy section.
- Adds a “Contributing Feedback” section in
README.mdto serve as the stable reference target.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/auto-close-pr.yml |
Expands trigger coverage and adjusts gating/permissions while updating the close message to include a policy link. |
README.md |
Adds a “Contributing Feedback” section intended to match the workflow’s guidance and provide a stable anchor link. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## Contributing Feedback | ||
|
|
||
| We currently do not accept pull requests to this repository. Please share ideas, | ||
| questions, and bug reports through the [Copilot community |
There was a problem hiding this comment.
The new README section routes feedback exclusively to Discussions, but the auto-close workflow message now says the project accepts "issues and discussions". To keep contributor guidance consistent (and keep the README anchor link accurate), update this section to match the workflow message (or update the workflow message to match the README).
| questions, and bug reports through the [Copilot community | |
| questions, and bug reports through GitHub issues or the [Copilot community |
| types: [opened, reopened, synchronize] | ||
|
|
||
| permissions: | ||
| pull-requests: write |
There was a problem hiding this comment.
The workflow still creates labels and adds a label to the PR (and posts a PR comment via gh pr close --comment), which uses the Issues API. With issues: write removed, these gh label create, gh pr edit --add-label, and the close comment are likely to fail with permission errors. Either add issues: write back, or adjust the workflow to avoid label/comment operations that require it.
| pull-requests: write | |
| pull-requests: write | |
| issues: write |
At the moment we are not accepting contributions to the repository.
The workflow review requested tighter fork-PR handling and clearer contributor messaging. This update keeps behavior focused on fork PR auto-closure while reducing permission scope and documenting the policy link used in the close comment.
Workflow scope and triggers (
.github/workflows/auto-close-pr.yml)synchronizetopull_request_targetevent types.issues: writepermission.iffor clearer execution gating.author_association == 'NONE'restriction so all fork PRs are handled consistently.PR_NUMBERpresence check before runningghcommands.Contributor guidance in close comment
https://github.com/github/CopilotForXcode#contributing-feedbackDocumentation alignment (
README.md)💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.