[Bug] Vietnamese choice labels are corrupted after pac code add-data-source

[DEVDinhDiem]

When running pac code add-data-source -a dataverse -t

, Dataverse Choice labels in Vietnamese are corrupted in generated code instead of being preserved correctly.

For example, labels with Vietnamese diacritics are transformed into malformed strings with underscores, such as Giaothietbi_n__ and Thanhto_ntrn__ckhinh_nh_ng.

Expected: Vietnamese/Unicode labels should be preserved correctly, or the generator should produce a safe identifier while keeping the original localized label separately.

Actual: Generated labels lose Vietnamese diacritics and become unreadable.

This seems to happen during code generation after adding a Dataverse data source, not during connection setup itself.

Attachments
I can provide a screenshot of the generated output showing the corrupted Vietnamese labels.

[eschavez]

Thanks for the clear repro and screenshot — this is a real bug in our code generator.

What's happening: When pac code add-data-source runs against a Dataverse table with Choice columns, the generated TypeScript const object maps each numeric optionset value to its display label. Our label-sanitization step incorrectly passes the raw display name through a function that strips all non-ASCII characters (replacing diacritics with underscores), which corrupts Vietnamese and other Unicode labels. So "Giao thiết bị" becomes Giaothietbi_n__ rather than the original string.

Workaround (until the fix ships): You can manually patch the generated file after running add-data-source. In the generated *-dataverse.ts file, find the const object for the affected column and replace the corrupted values with the correct Vietnamese strings — for example:

` s
// Replace this:
export const MyTablemychoicecolumn = {
1: 'Giaothietbi_n__',
} as const;

// With this:
export const MyTablemychoicecolumn = {
1: 'Giao thiết bị',
} as const;
`

You'll need to re-apply the patch after each add-data-source run until the fix is in.

We're tracking the fix internally and will update this issue when it's available.

[ergonza93]

The fix has been checked in and should be available with the next release