fix - only destroy subagent conversation, not the main conversation#174
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a regression where pressing the stop/cancel button destroyed the main CLS conversation, preventing the user from continuing the same chat session afterward (issue #173).
Changes:
- Remove
conversation/destroycall for the mainconversationIdwhen canceling. - Keep
conversation/destroyfor the temporarysubagentConversationIdon cancel. - Preserve/persist local conversation state while canceling in-flight futures and resetting UI state.
jdneo
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #173
Previously, clicking cancel (stop button) called conversation/destroy on both the main conversation and the subagent conversation. This caused the main conversation to be removed from CLS memory, making it impossible to continue the conversation after cancel.