Skip to content

In Agent mode: Auto scroll to prompts like 'Continue'. #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raghucssit wants to merge 2 commits into
base: main
Choose a base branch
from
Open

In Agent mode: Auto scroll to prompts like 'Continue'. #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
573d9e0
In Agent mode: Auto scroll to prompts like 'Continue'.
raghucssit Apr 27, 2026
7d4fc67
Merge branch 'main' into auto_scroll_to_prompt
jdneo Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions ...icrosoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/BaseTurnWidget.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import org.eclipse.ui.PlatformUI;
import org.osgi.service.event.EventHandler;

import com.microsoft.copilot.eclipse.core.Constants;
import com.microsoft.copilot.eclipse.core.CopilotCore;
import com.microsoft.copilot.eclipse.core.chat.ConfirmationContent;
import com.microsoft.copilot.eclipse.core.events.CopilotEventConstants;
Expand All @@ -36,6 +37,7 @@
import com.microsoft.copilot.eclipse.core.persistence.CopilotTurnData.EditAgentRoundData;
import com.microsoft.copilot.eclipse.core.persistence.CopilotTurnData.ReplyData;
import com.microsoft.copilot.eclipse.core.persistence.CopilotTurnData.ToolCallData;
import com.microsoft.copilot.eclipse.ui.CopilotUi;
import com.microsoft.copilot.eclipse.ui.chat.services.AvatarService;
import com.microsoft.copilot.eclipse.ui.chat.services.ChatServiceManager;
import com.microsoft.copilot.eclipse.ui.utils.SwtUtils;
Expand Down Expand Up @@ -604,16 +606,16 @@ protected void ensureFooterAtBottom() {
* @param code the server error code
* @param modelProviderName the BYOK model-provider name, or {@code null} for built-in models
*/
protected void createWarnDialog(String message, int code, String modelProviderName) {
protected Composite createWarnDialog(String message, int code, String modelProviderName) {
// TODO: Remove this legacy fallback after TBB is officially released.
// When the language server has not enabled token-based billing yet, restore the original
// main-branch warning behavior (no plan-driven actions; single upgrade button on the legacy
// 30-day free trial message).
if (!this.serviceManager.getAuthStatusManager().getQuotaStatus().tokenBasedBillingEnabled()) {
new WarnWidget(this, SWT.BOTTOM, message, code);
WarnWidget warnWidget = new WarnWidget(this, SWT.BOTTOM, message, code);
ensureFooterAtBottom();
requestLayout();
return;
return warnWidget;
}
boolean byokQuotaExceeded = QuotaActions.isByokQuotaExceeded(code, modelProviderName);
String displayMessage = byokQuotaExceeded ? Messages.chat_warnWidget_byokQuotaUsageMessage : message;
Expand All @@ -627,9 +629,10 @@ protected void createWarnDialog(String message, int code, String modelProviderNa
&& quotaStatus.premiumInteractions().overagePermitted();
canUpgradePlan = quotaStatus.canUpgradePlan();
}
new WarnWidget(this, SWT.NONE, displayMessage, planForActions, overageEnabled, canUpgradePlan);
WarnWidget warnWidget = new WarnWidget(this, SWT.NONE, displayMessage, planForActions, overageEnabled, canUpgradePlan);
ensureFooterAtBottom();
requestLayout();
return warnWidget;
}

/**
Expand Down Expand Up @@ -666,6 +669,20 @@ public CompletableFuture<LanguageModelToolConfirmationResult> requestToolExecuti

this.getParent().requestLayout();

// Ensure the chat content viewer scrolls to show the newly created confirmation
// dialog. Walk up the composite hierarchy to find a ChatContentViewer
// and request scrolling. Use async exec because layout needs to complete first.
SwtUtils.invokeOnDisplayThreadAsync(() -> {
ChatContentViewer viewer = SwtUtils.findParentOfType(this.getParent(), ChatContentViewer.class);
if (viewer != null) {
viewer.refreshScrollerLayout();

@jdneo jdneo Jun 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will happen if we not call viewer.refreshScrollerLayout(); here?

if (this.confirmDialog != null && !this.confirmDialog.isDisposed()) {
viewer.showControl(this.confirmDialog);
}
}

}, this.getParent());

return toolConfirmationFuture;
}

Expand Down
31 changes: 28 additions & 3 deletions ...osoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/ChatContentViewer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ public class ChatContentViewer extends ScrolledComposite {
// Auto-scroll state management
private boolean autoScrollEnabled;

private boolean scrolledToWidget;

/**
* Create the composite.
*
Expand Down Expand Up @@ -419,9 +421,21 @@ public BaseTurnWidget getTurnWidget(String turnId) {
}

private void renderWarnMessageWithUpgradePlanButton(String errorMessage, int code, String modelProviderName) {
latestTurnWidget.createWarnDialog(errorMessage, code, modelProviderName);
Composite warnWidget = latestTurnWidget.createWarnDialog(errorMessage, code, modelProviderName);
// Ensure the chat content viewer scrolls to show the newly created warning banner. Walk up the composite hierarchy
// to find a ChatContentViewer and request scrolling. Use async exec because layout needs to complete first.
scrolledToWidget = false;
SwtUtils.invokeOnDisplayThreadAsync(() -> {
if (warnWidget != null && !warnWidget.isDisposed()) {
showControl(warnWidget);
scrolledToWidget = true;
}

}, this.getParent());
refreshScrollerLayout();
scrollToLatestUserTurn();
if (!scrolledToWidget) {

@jdneo jdneo Jun 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little bit confused here.

scrolledToWidget is set to true in an async call, which means, when code is executed to here, highly likely the scrolledToWidget is still false.

What will happen if we always scroll to warn/error widget after it is created and not call scrollToLatestUserTurn() after that?

@raghucssit raghucssit Jun 17, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scrollToLatestUserTurn() this call takes the scroll back to last user turn widget. That is if i have asked some question to copilot. This behavior also not good because there is no benefit to scroll there. I wanted not to change existing behavior that's why i cam e up with this work around.
In my testing everything was working fine because async always executed before we access scrolledToWidget.
But my proposal is to remove call to scrollToLatestUserTurn() is better. Because itreally does not have have any benefit.
If you agree on my proposal i will fix this.

@raghucssit raghucssit Jun 23, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdneo Please confirm this behavior change looks ok ? From my POV it is good to implement my proposal i don't see any benefits of old behavior.

@jdneo jdneo Jun 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raghucssit Sorry for the late response. I was working on sth else recently. Will check this ASAP.

@jdneo jdneo Jun 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But my proposal is to remove call to scrollToLatestUserTurn() is better. Because itreally does not have have any benefit.

I have the same feeling as yours. Since showControl already reveals the component that needs to pay attention, another scrollToLatestUserTurn() is not necessary.

scrollToLatestUserTurn();
}
}

/**
Expand All @@ -433,7 +447,18 @@ public void renderErrorMessage(String errorMessage) {
}
this.errorWidget = new ErrorWidget(cmpContent, SWT.BOTTOM, errorMessage);
refreshScrollerLayout();
scrollToLatestUserTurn();
// Ensure the chat content viewer scrolls to show the newly created error banner.
scrolledToWidget = false;
SwtUtils.invokeOnDisplayThreadAsync(() -> {
if (this.errorWidget != null && !this.errorWidget.isDisposed()) {
this.showControl(this.errorWidget);
scrolledToWidget = true;
}
}, this.getParent());

if (!scrolledToWidget) {
scrollToLatestUserTurn();
}
}

/**
Expand Down
22 changes: 22 additions & 0 deletions com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/utils/SwtUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,30 @@ private SwtUtils() {
}

private static final String INLINE_ANNOTATION_COLOR_KEY = "org.eclipse.ui.editors.inlineAnnotationColor";

private static final int DEFAULT_GHOST_TEXT_SCALE = 128;

/**
* Walks up the parent chain of the given control and returns the first ancestor that is an instance of the specified
* type, or {@code null} if none is found.
*
* @param <T> the target type
* @param control the starting control (may be {@code null})
* @param type the class to search for
* @return the first matching ancestor, or {@code null}
*/
@Nullable
public static <T> T findParentOfType(Control control, Class<T> type) {
Comment thread
raghucssit marked this conversation as resolved.
Control current = control;
while (current != null) {
if (type.isInstance(current)) {
return type.cast(current);
}
current = current.getParent();
}
return null;
}

/**
* Invokes the given runnable on the display thread.
*/
Expand Down