[Feat] Read the default text editor preferences from platform instead of defaulting to spaces.#267
Merged
Merged
Conversation
Read the default text editor preferences from Eclipse instead of defaulting to spaces by default.
jomillerOpen
requested review from
duzitong,
ethanyhou,
jdneo and
xinyi-gong
as code owners
Contributor
Author
|
@microsoft-github-policy-service agree company="OpenText" |
Contributor
Author
|
Implements/satisfies #238 |
jdneo
reviewed
May 29, 2026
Switch to using the Platform.getPreferencesService() method instead, which will correctly account for the instances.
Contributor
Author
|
I didn't know about that until now! But yes, I tried using it and it seems to work find as well. I'll switch it to that. |
Member
|
@jomillerOpen Looks good! Please fix the test failure, thank you.
|
Updated test to also retrieve the same values.
Member
|
CI still failed, pls refer to #273 |
Return the Eclipse settings when the file isn't part of a project or doesn't have an extension.
Contributor
Author
|
There we go. Passed locally. Had to return the Eclipse options for the 2 other scenarios where a file isn't part of a handled project. |
jdneo
reviewed
Jun 3, 2026
Updated test to set the preferences and then test.
jdneo
approved these changes
Jun 4, 2026
jdneo
left a comment
jdneo
left a comment
Member
There was a problem hiding this comment.
LGTM, thank you for your contribution!
jdneo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read the default text editor preferences from Eclipse instead of defaulting to spaces by default. To avoid having additional plug-in dependencies, we use the existing preferences plug-in to check the multiple workspace instances for the settings. The 2 settings are the "spacesForTabs" and "tabWidth". If those settings are found, we will use those for the formatting options. If not, then it will continue to fall back to using defaults of using spaces. These settings are in effect when a project is neither a Java or C project type.