What's your best advice for writing clear and effective pull requests? #161310
-
Select Topic AreaQuestion Body👋 Hi everyone, I'm looking to get better at writing clear and helpful pull requests — especially when they’re a bit larger than usual — and I’d love to learn from your experience. ▸ Do you follow any structure or checklist when opening a PR? Would really appreciate any thoughts or examples you’re willing to share. Thanks so much! |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 1 reply
-
|
If you are part of a team usually you would try to divide the contributions in small changes (by functionality, fix, change, update...). However when working on some project it happens that we usually make a lot of contributions in one branch, in this case i feel the right thing to do would be to name the pull request with the main change done to the project, like for example-> add: logic for users, events, chat and auth. In the case you are contributing to some open source project and even after following the guidelines for contributing you still end up with a big name for the PR, like for example: "cat, ls, tree, mkdir, man, cd, chdir, chmod, fdisk, lf, echo, ...: add Chinese translation" then it would just be a mass change contribution, but it would actually be of a major functionality, in the example a translation you specify the commands for which you are making the translation so it is actually pretty clear what you've done and the name of the PR is clear: you added the chinese translation to all those commands. If you wanted to simplify this you could write pages.zh/common/a*: add some missing translations I hope this helps :) |
Beta Was this translation helpful? Give feedback.
-
|
Hey friend! Let’s craft clear, fun PRs that reviewers love—split into prefixes and emojis for max impact! 🛠️ PR Cheat Sheet: Prefixes Write it like a note to future you—short and sharp: Title That Tells a Story Skip: "Changes" Try: "fix: Login redirect for expired sessions" Prefixes like fix:, feat: signal the goal! The 3-Sentence Summary "Hey team! This fix: tackles the redirect loop from expired sessions (see #123)." Changes Made Simple Explain to a non-tech pal: "fix: Cleaned up cookies in logout.js" "test: Added checks for session bugs" "docs: Updated session limit guide" 🛠️ PR Cheat Sheet: Emojis Write it like a note to future you—simple and lively: Title That Tells a Story Skip: "Changes" Try: "🐛 Login redirect for expired sessions" Emojis like 🐛 or ✨ hint at the vibe! The 3-Sentence Summary "👋 Hey team! This 🐛 zaps the redirect loop from expired sessions (see #123)." "Cause: missing cookie cleanup in logout handler." "✅ Tested on Chrome, Firefox, Safari—smooth sailing!" Changes Made Simple Explain to a non-tech pal: "🐛 Cleaned up cookies in logout.js" "✅ Added checks for session bugs" "📝 Updated session limit guide" 🤯 Making Big PRs Less Scary: Prefixes Prefix Power: "fix:" Bug squashes (e.g., "fix: Patch login timeout") Tips: Small commits, clear prefixes, welcome feedback! Emoji Power: "🐛" Bug fixes (e.g., "🐛 Patch login timeout") "✨" New features (e.g., "✨ Add dark mode toggle") "📝" Doc updates (e.g., "📝 Clarify API usage") "✅" Test additions (e.g., "✅ Validate payment flow") "🧹" Small stuff (e.g., "🧹 Update dependencies") "🔧" Code cleanup (e.g., "🔧 Simplify auth logic") Tips: Small commits, fun emojis, open to feedback. You’re a star! 🌟 Resources: GitHub PR Basics Commit Message Tricks Conventional Commits |
Beta Was this translation helpful? Give feedback.
Hey friend! Let’s craft clear, fun PRs that reviewers love—split into prefixes and emojis for max impact!
🛠️ PR Cheat Sheet: Prefixes
Write it like a note to future you—short and sharp:
Title That Tells a Story
Skip: "Changes"
Try: "fix: Login redirect for expired sessions"
Prefixes like fix:, feat: signal the goal!
The 3-Sentence Summary
"Hey team! This fix: tackles the redirect loop from expired sessions (see #123)."
"Cause: missing cookie cleanup in logout handler."
"Tested on Chrome, Firefox, Safari—rock solid!"
Changes Made Simple
Explain to a non-tech pal:
"fix: Cleaned up cookies in logout.js"
"test: Added checks for session bugs"
"docs: Updated session limit guide"
🛠️ PR Cheat She…