Markdown code blocks ignore tab width setting

[michaldudak]

While the Settings/Appearance/Tab size preference works great when viewing code, it seems to be ignored by the code rendered in Markdown blocks, i.e.:

function foo() {
	if (this.workedCorrectly()) {
		i.wouldntSeeTabSizeEqualTo(8);
	}
}

looks like

even though my Tab size preference is set to 4.

It would be even better if the markdown renderer took the root .editorconfig from the repo into consideration.

[adamburgess]

this should've been tested when they added tab size to settings :/ I would like this too.

for now, this custom css works for me:

html {
	tab-size: 4;
}

[lPadier]

This also seems to be the case for markdown blocks in .md files, as can be seen on the preact project README: as it uses the same implementation (highlight.js).

[adamburgess]

looks like someone was reading Rich Harris's twitter ;)

[BenjaminAster]

@dipree Please take a look at this!

[danawoodman]

For anyone not willing to wait for Github to get around to this, install a CSS customization extension (say "Custom CSS by Denis") and then just set html { tab-size: 2 } or whatever you want in the extension.

Will be applied globally and fix this till Github pushes a proper fix.

[NickStrupat]

Still not fixed in March 2023...

[ajtruckle]

I seem to have issues too with code blocks in my Discussions area. They show with 8 instead of 4.

[lionel-rowe]

Please fix this, I've literally never met anyone who prefers gigantic 8-char-wide tabs over 4-char or 2-char ones. TBH I don't know why they don't just change the default, other than that it's the browser default for some reason.

[chase-moskal]

for so many years, this bug has forced me to use spaces in my readmes, so my code examples don't look stupid.

in the time i've been patiently waiting for this fix, my boyish youth has faded, leaving me an aged, bitter, jaded husk of the potential i once had. thanks, github

[github-actions[bot]]

💬 Your Product Feedback Has Been Submitted 🎉

Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users.

Here's what you can expect moving forward ⏩

• Your input will be carefully reviewed and cataloged by members of our product teams. 
  • Due to the high volume of submissions, we may not always be able to provide individual responses.
  • Rest assured, your feedback will help chart our course for product improvements.
• Other users may engage with your post, sharing their own perspectives or experiences. 
• GitHub staff may reach out for further clarification or insight. 
  • We may 'Answer' your discussion if there is a current solution, workaround, or roadmap/changelog post related to the feedback.

Where to look to see what's shipping 👀

• Read the Changelog for real-time updates on the latest GitHub features, enhancements, and calls for feedback.
• Explore our Product Roadmap, which details upcoming major releases and initiatives.

What you can do in the meantime 💻

• Upvote and comment on other user feedback Discussions that resonate with you.
• Add more information at any point! Useful details include: use cases, relevant labels, desired outcomes, and any accompanying screenshots.

As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities.

Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐

[moraesc]

Hey everyone! I'm excited to announce that we've recently fixed this issue by making user-defined tab-width preferences consistent across GitHub (see changelog here). Feel free to test this out and drop a comment in our community discussion if you have any feedback or run into any issues.

[cehfisher]

Hello @michaldudak - could you please re-test the issue you reported and let us know if it’s been resolved? You can either leave a comment and close it out yourself, or if there’s no activity for 1–2 weeks, the system will automatically close it. Thanks!

[ajtruckle]

My discussions seem better if that helps. No longer showing with 8 spaces per tab.

[michaldudak]

Yes, it works well, thank you!

[chase-moskal]

i converted my readme to tabs, and it revealed that github's codeblock rendering is actually broken.

please see this example i made in this gist: https://gist.github.com/chase-moskal/0714c9b5e974f99162774d24524a099a

github mangles codeblocks nested under bullet list items. not sure if this bug is new, or always existed.

i'll also post about this in that new discussion

[cehfisher]

Thank you @chase-moskal for sharing this feedback! The accessibility and UX teams are looking into this and will have more information for you soon.