Skip to content

kimber grace and rain threshold implementation differences #2796

Description

@mikofski

Describe the bug

  1. the threshold in pvlib is strict...

    rain_events = accumulated_rainfall > cleaning_threshold

    ...whereas the paper Kimber, 2006 implies that rainfall inclusive of the threshold is sufficient to clean:
    Image

  2. the grace period has an off-by-one error, including the rain day and therefore effectively reducing grace days to gracedays-1

To Reproduce

  1. set rainfall to exactly the value of rainfall in the accumulation period and it will not clean
  2. set grace days to 1, and effectively here are no grace days!

Expected behavior

  1. rainfall equal to should clean
  2. grace day of 1 should be clean for 1 day after rainfall event

Versions:

  • pvlib.__version__: 0.15.2

Additional context
Thank you @wholmgren for pointing out these inconsistencies!

May also be related to

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions