@require can't work well after upgrading to 4.3.0

// @require      https://lf26-cdn-tos.bytecdntp.com/cdn/expire-1-M/nprogress/0.2.0/nprogress.min.js
// @require      https://lf26-cdn-tos.bytecdntp.com/cdn/expire-1-M/clipboard.js/2.0.10/clipboard.min.js

Above files use the keywords this, but it's always undefined when script injection.

I found the latest changes that make the scripts run in strict mode, and @require also in strict mode .

userscripts/extension/Userscripts Extension/Resources/content.js

Line 244 in 479eff5

"use strict";

[quoid]

@4ooc

Thanks for reporting the issue. When I @require one of those js files, I can see the error. I believe I have a fix for this.

Would it be possible to provide a test userscript for this issue? Perhaps something that includes one of those @require values and a simple a test? I am not sure what those required libraries are supposed to do.

Thank you

// ==UserScript==
// @name        NewScript-i999ds1t
// @description This is your new file, start writing code
// @match       *://*/*
// @require     https://lf26-cdn-tos.bytecdntp.com/cdn/expire-1-M/nprogress/0.2.0/nprogress.min.js
// ==/UserScript==

$('head').append("<style>#nprogress{pointer-events:none}#nprogress .bar{background:#f44444;position:fixed;z-index:1031;top:0;left:0;width:100%;height:2px}#nprogress .peg{display:block;position:absolute;right:0;width:100px;height:100%;box-shadow:0 0 10px #f44444,0 0 5px #f44444;opacity:1;-webkit-transform:rotate(3deg) translate(0,-4px);-ms-transform:rotate(3deg) translate(0,-4px);transform:rotate(3deg) translate(0,-4px)}#nprogress .spinner{display:block;position:fixed;z-index:1031;top:15px;right:15px}#nprogress .spinner-icon{width:18px;height:18px;box-sizing:border-box;border:solid 2px transparent;border-top-color:#f44444;border-left-color:#f44444;border-radius:50%;-webkit-animation:nprogress-spinner .4s linear infinite;animation:nprogress-spinner .4s linear infinite}.nprogress-custom-parent{overflow:hidden;position:relative}.nprogress-custom-parent #nprogress .bar,.nprogress-custom-parent #nprogress .spinner{position:absolute}@-webkit-keyframes nprogress-spinner{0%{-webkit-transform:rotate(0)}100%{-webkit-transform:rotate(360deg)}}@keyframes nprogress-spinner{0%{transform:rotate(0)}100%{transform:rotate(360deg)}}</style>");
NProgress.start();
process=0
iv=setInterval(()=>{
  NProgress.set(process/100)
  console.log(process)
  if(process>=100){
    clearInterval(iv)
  }
  process+=10
}, 500)
NProgress.done();

Like this?

[ACTCD]

Just considering this issue, the use case is to assign the API property to the global in the require library, this should not actually be an issue in well-written libraries, such as jQuery wrapper.

So we're actually dealing with a situation that is compatible with a non-well-written library or user script. As @quoid said, it is easy to fix this issue, but we should still encourage script/library developers to write modern and more robust code.

Strict Mode brings many benefits, and simplify some complex considerations and security issues, which optimize performance. If it does not cause more damage, we should to consider the advantages and disadvantages of this choice more carefully.

Please don't be nervous, this issue will be fixed with compatibility, thank you for your use case.

[quoid]

@4ooc

Like this?

I think there might be some errors in that javascript and maybe should also @require jquery?

process=0
iv=setInterval

Both process and iv and undefined. I can add:

var process=0 & iv=setInterval and @require jquery to get it to function.

@4ooc

Like this?

I think there might be some errors in that javascript and maybe should also @require jquery?

process=0
iv=setInterval

Both process and iv and undefined. I can add:

var process=0 & iv=setInterval and @require jquery to get it to function.

Sorry, I could't run script with @require nprogress.min.js via userscripts extension now. So I run it via another extension.

[quoid]

@4ooc all good, hotfix should be landing on the app store once it gets approved by apple