Skip to content

Refactor popup development experience#440

Merged
ACTCD merged 4 commits into
masterfrom
refactor/popup_dev
Mar 6, 2023
Merged

Refactor popup development experience#440
ACTCD merged 4 commits into
masterfrom
refactor/popup_dev

Conversation

@ACTCD

@ACTCD ACTCD commented Mar 4, 2023

Copy link
Copy Markdown
Collaborator
  • Random getCurrent urls, simulating different situations
  • Random current url script installed status
  • Add border and offset to popup, better preview
dev-popup.mp4

@ACTCD ACTCD requested a review from quoid March 4, 2023 20:00
@ACTCD ACTCD requested review from quoid and removed request for quoid March 4, 2023 20:24
quoid
quoid approved these changes Mar 6, 2023
View reviewed changes

@quoid quoid left a comment •
edited
Loading

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and worked well when tested.

I noticed when testing I didn't really like the randomization, but it's very simple to comment out elements from the random arrays and makes setting the responses I want easier than before.

@ACTCD ACTCD merged commit 5f51319 into master Mar 6, 2023
@ACTCD ACTCD deleted the refactor/popup_dev branch March 6, 2023 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quoid quoid quoid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ACTCD @quoid