fix: avoid potentially infinite hangs on async messages#669
Merged
Conversation
quoid
approved these changes
Jul 10, 2024
quoid
left a comment
quoid
left a comment
Owner
There was a problem hiding this comment.
Code changes make sense to me 👍.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using GM APIs, if the background script returns an
undefinedvalue, the reply may never be delivered, and awaiting the promise will cause the script to hang indefinitely.The issue existed in the latest release version, but since
undefinedvalues were not returned in most cases, it was unlikely that the error would be encountered except in some edge cases.However, with the revise of GM APIs in #570 (currently still in beta versions), which brought in more possibilities of returning
undefinedvalues, the issue was finally exposed.Fix this by avoiding returning any
undefinedvalues, use predefined structured message objects.