Skip to content

refactor: use dynamic rules for dnr and improvements#684

Merged
ACTCD merged 1 commit into
mainfrom
refactor/dnr-simple-optimization
Aug 3, 2024
Merged

refactor: use dynamic rules for dnr and improvements#684
ACTCD merged 1 commit into
mainfrom
refactor/dnr-simple-optimization

Conversation

@ACTCD

@ACTCD ACTCD commented Aug 3, 2024

Copy link
Copy Markdown
Collaborator

Use dynamic ruleset instead of session ruleset to resolve #683.

Simply refactor the DNR adding process to improve fault tolerance and error handling.

@ACTCD ACTCD requested a review from quoid August 3, 2024 00:46

@quoid quoid left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can quite remember why I originally used session rules over dynamic rules. There was a reason, but it eludes me. Maybe after this is merged I will remember, but for the time being looks good to me.

@ACTCD ACTCD merged commit 521ea59 into main Aug 3, 2024
@ACTCD ACTCD deleted the refactor/dnr-simple-optimization branch August 3, 2024 03:01
@ACTCD

ACTCD commented Aug 3, 2024

Copy link
Copy Markdown
Collaborator Author

I can quite remember why I originally used session rules over dynamic rules. There was a reason, but it eludes me. Maybe after this is merged I will remember, but for the time being looks good to me.

Nothing obvious negatives comes to mind. Except that we do have to be careful about how long it lasts.
I noticed that even if I deleted the app, the previous ruleset was still there after the next installation.
Of course, these rules will not take effect after the App is deleted, but they are not deleted at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

If you search in Safari from Spotlight while Safari is closed, the @run-at request script will not work.

2 participants