You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
I can quite remember why I originally used session rules over dynamic rules. There was a reason, but it eludes me. Maybe after this is merged I will remember, but for the time being looks good to me.
I can quite remember why I originally used session rules over dynamic rules. There was a reason, but it eludes me. Maybe after this is merged I will remember, but for the time being looks good to me.
Nothing obvious negatives comes to mind. Except that we do have to be careful about how long it lasts.
I noticed that even if I deleted the app, the previous ruleset was still there after the next installation.
Of course, these rules will not take effect after the App is deleted, but they are not deleted at the same time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
dynamic rulesetinstead ofsession rulesetto resolve #683.Simply refactor the DNR adding process to improve fault tolerance and error handling.