Skip to content

feat(macos): do not open safari when change save location #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ACTCD merged 1 commit into from
Sep 28, 2024
Merged

feat(macos): do not open safari when change save location #731

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions xcode/App-Mac/ViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,16 @@ class ViewController: NSViewController {
// update user interface text display
self.saveLocation.stringValue = url.absoluteString
self.saveLocation.toolTip = url.absoluteString
// notify browser extension of relevant updates
sendExtensionMessage(
name: "SAVE_LOCATION_CHANGED",
userInfo: [
"saveLocation": url.absoluteString.removingPercentEncoding ?? url.absoluteString,
"returnApp": true
]
)
// notify browser extension of relevant updates only when Safari is running
if !NSRunningApplication.runningApplications(withBundleIdentifier: "com.apple.Safari").isEmpty {
sendExtensionMessage(
name: "SAVE_LOCATION_CHANGED",
userInfo: [
"saveLocation": url.absoluteString.removingPercentEncoding ?? url.absoluteString,
"returnApp": true
]
)
}
})
}

Expand Down