Skip to content

fix(deploy): personal user unit 실행 인자 보정#53

Merged
pureliture merged 1 commit into
mainfrom
codex/personal-prod-unit-fixes
Jun 21, 2026
Merged

fix(deploy): personal user unit 실행 인자 보정#53
pureliture merged 1 commit into
mainfrom
codex/personal-prod-unit-fixes

Conversation

@pureliture

Copy link
Copy Markdown
Contributor

What

  • personal scan-worker user unit에서 CLI가 지원하지 않는 --notification-log 인자를 제거했습니다.
  • lease-reaper timer에 OnActiveSec=2min을 추가해 enable 직후 첫 schedule이 생기게 했습니다.
  • personal-prod unit structure test를 보강했습니다.

Why

  • remote deploy에서 worker daemon이 INVALIDARGUMENT로 restart loop에 들어갔고, lease-reaper timer는 next schedule이 비어 있었습니다.

Validation

  • uv run pytest tests/test_personal_prod_systemd_units.py -q
  • uv run pytest -q
  • uv run python -m governance.autopilot_gate --base origin/main

scan-worker CLI에 없는 --notification-log 인자를 제거해 user worker daemon이 정상 기동되게 한다.

lease-reaper timer는 OnActiveSec를 추가해 enable 직후 첫 schedule이 생기도록 보정한다.

검증: uv run pytest tests/test_personal_prod_systemd_units.py -q && uv run pytest -q && uv run python -m governance.autopilot_gate --base origin/main

Co-Authored-By: Codex GPT-5 <noreply@openai.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the systemd configuration files and their corresponding tests. Specifically, it adds OnActiveSec=2min to the lease reaper timer, removes the --notification-log argument from the personal scan worker service, and updates the unit tests to assert these changes. The reviewer suggested removing the Persistent=true option from the lease reaper timer because it is ineffective for monotonic timers (like OnActiveSec and OnUnitActiveSec) and can cause systemd warnings.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread deploy/systemd/user/security-scanner-personal-lease-reaper.timer
@pureliture pureliture merged commit 7eb337e into main Jun 21, 2026
9 checks passed
@pureliture pureliture deleted the codex/personal-prod-unit-fixes branch June 21, 2026 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant