Skip to content

fix(discovery): empty repo poll을 incremental fresh로 처리#54

Merged
pureliture merged 1 commit into
mainfrom
codex/personal-prod-unit-fixes
Jun 21, 2026
Merged

fix(discovery): empty repo poll을 incremental fresh로 처리#54
pureliture merged 1 commit into
mainfrom
codex/personal-prod-unit-fixes

Conversation

@pureliture

Copy link
Copy Markdown
Contributor

What

  • refs가 없는 repo를 successful discovery poll에서 incremental fresh로 advance합니다.
  • empty/no-HEAD repo regression test를 추가했습니다.
  • touched discovery test/module에 ruff 정리를 적용했습니다.

Why

  • personal-prod seed 중 empty repo는 baseline scan은 완료되지만 incremental commit job을 만들 수 없어 freshness evaluator가 계속 stale breach로 남겼습니다.

Validation

  • uv run ruff check src/security_scanner/runtime/incremental_discovery.py tests/test_incremental_discovery.py
  • uv run pytest tests/test_incremental_discovery.py -q
  • uv run pytest -q
  • uv run python -m governance.autopilot_gate --base origin/main

refs가 없는 repo는 successful discovery poll에서 스캔할 commit이 없으므로 incremental health를 advance한다.

이 처리로 empty/no-HEAD repo가 초기 배포 직후 계속 stale breach로 남는 상황을 방지한다.

검증: uv run ruff check src/security_scanner/runtime/incremental_discovery.py tests/test_incremental_discovery.py && uv run pytest tests/test_incremental_discovery.py -q && uv run pytest -q && uv run python -m governance.autopilot_gate --base origin/main

Co-Authored-By: Codex GPT-5 <noreply@openai.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the incremental discovery process to advance the repository health status even when no new references are found, along with adding a corresponding test case. The reviewer recommended calling request.store.advance_repo_health directly instead of using getattr to dynamically check for the method, as it is a required part of the IncrementalScanStore protocol and dynamic checking could silently mask incomplete store implementations.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/security_scanner/runtime/incremental_discovery.py
@pureliture pureliture merged commit 66aa165 into main Jun 21, 2026
9 checks passed
@pureliture pureliture deleted the codex/personal-prod-unit-fixes branch June 21, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant