Allow `@TestBean` on non-static methods

[hfhbd]

Enhancements request

The current syntax to inject a bean in a test is somehow confusing: it requires a field annotated with @TestBean and also a static method. When you use Kotlin, you also need a companion object and @JvmStatic

Ideally, you only need a non static method annotated with @TestBean. This is also symmetric to a regular bean definition.

@SpringBootTest
class CurrentServiceTest {
  @TestBean lateinit var myBean: MyBean

  @Test
  fun testMyService(@Autowired myService: MyService) {}

  companion object {
    @JvmStatic
    fun myBean(): MyBean = MyTestBean()
  }
}

@SpringBootTest
class SimplifiedServiceTest {
  @Test
  fun testMyService(@Autowired myService: MyService) {}

  @TestBean
  fun myBean(): MyBean = MyTestBean() 
}

[sbrannen]

Hi @hfhbd,

Congratulations on opening your first issue for the Spring Framework! 👍

The current syntax to inject a bean in a test is somehow confusing: it requires a field annotated with @TestBean and also a static method.

That's by design, and this topic is somewhat related to:

• Allow @DynamicPropertySource on non-static methods #24825

Ideally, you only need a non static method annotated with @TestBean.

I understand your desire for that; however, it is not feasible to make the @TestBean methods non-static, since the Spring TestContext Framework has no access to the test class instance when preparing the beans in the ApplicationContext. In other words, we would have to instantiate the test class prematurely and throw the instance away, which is something we do not want to do.

This is also symmetric to a regular bean definition.

Not exactly. A regular @Bean factory method resides either in a @Configuration class or a within the class of a component registered with the ApplicationContext. Whereas, a @TestBean method resides in a test class (or some other class within the test suite).

When you use Kotlin, you also need a companion object and @JvmStatic

That's unfortunately how Kotlin works with regard to static methods.

In light of the above, I am closing this issue.

Regards,

Sam