fix: correct indent calculation for shiftwidth=0#116
Open
xlucn wants to merge 1 commit intozbirenbaum:masterfrom
Open
fix: correct indent calculation for shiftwidth=0#116xlucn wants to merge 1 commit intozbirenbaum:masterfrom
xlucn wants to merge 1 commit intozbirenbaum:masterfrom
Conversation
Fixed the logic for calculating indentation in format.lua. Previously in the case of shiftwidth=0, the indent was not using the value of tabstop, leading to incorrect indentation.
zhimsel
added a commit
to zhimsel/dotfiles
that referenced
this pull request
Sep 3, 2024
This should be reverted when zbirenbaum/copilot-cmp#116 is merged
|
Just tested this PR with Thanks @xlucn! |
|
@zbirenbaum any chance of this getting merged any time soon? |
|
The help says to "use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing some cases in #45. Fixed the logic for calculating indentation in format.lua. Previously in the case of shiftwidth=0, the indent was not using the value of tabstop, leading to incorrect indentation.