Entity extend#8
Merged
Merged
Conversation
masicek
commented
May 24, 2024
masicek
commented
Contributor
- Podpora dávkového vkládání záznamů do DB
- Podpora ukládání parametrů pro spuštění jobu ve formátu JSON
| 'onError' => Expect::type('callable')->nullable(), | ||
| 'onAfterProcess' => Expect::type('callable')->nullable(), | ||
| 'onProcessingGetMetadata' => Expect::type('callable')->nullable(), | ||
| 'parametersFormat' => Expect::string()->nullable(), |
Contributor
There was a problem hiding this comment.
Nejde tady dát něco jako enum?
Contributor
Author
There was a problem hiding this comment.
Bylo by to moc komplikované, pokud chceme v neno konfigu pak použít např.
parametersFormat: @ADT\BackgroundQueue\Entity\BackgroundJob::PARAMETERS_FORMAT_JSON
při definici jako je tato
'parametersFormat' => Expect::anyOf(BackgroundJob::PARAMETERS_FORMAT_SERIALIZE, BackgroundJob::PARAMETERS_FORMAT_JSON)->default(BackgroundJob::PARAMETERS_FORMAT_SERIALIZE),
Pak nám to hlásí chybu.
The item 'backgroundQueue › parametersFormat' expects to be 'serialize'|'json', '@ADT...' given.
Nechal bych volitelně string a kontrola je pak v hlavní knihovně BacgroundQueue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.