Skip to content

Entity extend #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thorewi merged 3 commits into from
May 29, 2024
Merged

Entity extend #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07033c5
Podpora dávkového vkládání záznamů do DB
May 24, 2024
a04170e
Podpora ukládání parametrů pro spuštění jobu ve formátu JSON
May 24, 2024
d244a23
Update composer.json
May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"license": "MIT",
"require": {
"php": "^7.4|^8.0",
"adt/background-queue": "^4.21",
"adt/background-queue": "^4.22",
"nette/di": "^2.4|^3.0",
"nette/schema": "^1.2"
},
Expand Down
2 changes: 2 additions & 0 deletions src/DI/BackgroundQueueExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ public function getConfigSchema(): Schema
'tempDir' => Expect::string()->required(),
'locksDir' => Expect::string()->required(),
'queue' => Expect::string()->required(),
'bulkSize' => Expect::int(1)->min(1),
'priorities' => Expect::arrayOf(Expect::int()->min(1))->default([1])->mergeDefaults(false),
'connection' => Expect::anyOf('string', Expect::arrayOf('int|string|object', 'string')),
'tableName' => Expect::string('background_job'),
Expand All @@ -45,6 +46,7 @@ public function getConfigSchema(): Schema
'onError' => Expect::type('callable')->nullable(),
'onAfterProcess' => Expect::type('callable')->nullable(),
'onProcessingGetMetadata' => Expect::type('callable')->nullable(),
'parametersFormat' => Expect::string()->nullable(),

@michallohnisky michallohnisky May 24, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nejde tady dát něco jako enum?

@masicek masicek May 27, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bylo by to moc komplikované, pokud chceme v neno konfigu pak použít např.

parametersFormat: @ADT\BackgroundQueue\Entity\BackgroundJob::PARAMETERS_FORMAT_JSON

při definici jako je tato

'parametersFormat' => Expect::anyOf(BackgroundJob::PARAMETERS_FORMAT_SERIALIZE, BackgroundJob::PARAMETERS_FORMAT_JSON)->default(BackgroundJob::PARAMETERS_FORMAT_SERIALIZE),

Pak nám to hlásí chybu.

The item 'backgroundQueue › parametersFormat' expects to be 'serialize'|'json', '@ADT...' given.

Nechal bych volitelně string a kontrola je pak v hlavní knihovně BacgroundQueue.

]);
}

Expand Down