Respect &splitbelow and &splitright

[teoljungberg]

This commit changes the split behavior to respect to the value of
&splitbelow and &splitright, which are both disabled by default.

This behavior was introduced in #950.

[deathbeam]

Shouldnt this then use topleft when splitbelow is not set? and same for splitting vertically with splitright?

[teoljungberg]

Shouldnt this then use topleft when splitbelow is not set? and same for splitting vertically with splitright?

It works with :split by default, but I can add topleft to the codepaths to clarify if you want to!

[deathbeam]

Shouldnt this then use topleft when splitbelow is not set? and same for splitting vertically with splitright?

It works with :split by default, but I can add topleft to the codepaths to clarify if you want to!

Are you sure? The point of botright/topleft is to make full width/full height split. So if you have 2 splits and you open copilot chat, it makes full widht/full height split properly instead of making smaller split inside of your current window

[teoljungberg]

Pushed to respect both &splitbelow and &splitright, and to use topleft when either are not set.

What this what you had in mind @deathbeam ?

[deathbeam]

yes this looks good to me thanks

[deathbeam]

@all-contributors add @teoljungberg for code

[allcontributors]

@deathbeam

I've put up a pull request to add @teoljungberg! 🎉