Skip to content

fix: properly split chat horizonatally/vertically when existing split…#950

Merged
deathbeam merged 1 commit intoCopilotC-Nvim:mainfrom
deathbeam:properly-split
Mar 9, 2025
Merged

fix: properly split chat horizonatally/vertically when existing split…#950
deathbeam merged 1 commit intoCopilotC-Nvim:mainfrom
deathbeam:properly-split

Conversation

@deathbeam
Copy link
Copy Markdown
Collaborator

…s are open

…s are open

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
@deathbeam deathbeam added the bug Something isn't working label Mar 9, 2025
@deathbeam deathbeam merged commit 82708c1 into CopilotC-Nvim:main Mar 9, 2025
2 checks passed
@deathbeam deathbeam deleted the properly-split branch March 9, 2025 17:37
teoljungberg added a commit to teoljungberg/CopilotChat.nvim that referenced this pull request Mar 18, 2025
This commit changes the horizontal split behavior to respect to the
value of &splitbelow, which defaults to being disabled.

This behavior was introduced in CopilotC-Nvim#950.
deathbeam pushed a commit that referenced this pull request Mar 18, 2025
* Respect &splitbelow

This commit changes the horizontal split behavior to respect to the
value of &splitbelow, which defaults to being disabled.

This behavior was introduced in #950.

* Adhere to &splitbelow for vertical as well

* Use nvim_get_option_value() instead of deprecated function

* Use topleft when not &splitbelow

* Use &splitright for vertical, not &splitbelow

* Use topleft for vertical when not &splitright
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant