Fix settings sync login and "loading" text

[code-asher]

Currently if you hover over the account login when you aren't logged in it just says "loading".

This is what it should look like instead:

Pressing "turn on settings sync" then takes you through the login process. It allows you to sign in with Microsoft and GitHub although I'm not sure we'll be able to support both or only GitHub.

---

If you are already logged in (to GitHub) supposedly syncing works and the icon works fine too but we should verify this.

---

Previous issues: #2587 #2913

[code-asher]

Interestingly if you have the GitHub pull request extension installed the icon works but there is still no sync.

After poking around it seems that settings sync is intentionally not included in the OSS.

So we'll still want to have the "you are not signed in" verbiage when you aren't signed in and there are no extensions providing auth but we won't have the "turn on settings sync" option.

And then at a later date perhaps we can look into implementing sync.

[johnsonw]

After poking around it seems that settings sync is intentionally not included in the OSS.
Any particular reason? My VS Code local install shows it here:

But when I go to the remote container it's missing as you said:

Just wondering why this would be intentional?

[code-asher]

I can make guesses but I don't know for sure why it's not available for OSS builds. Here is the comment from one of the VS Code devs but there is no further explanation: microsoft/vscode#105310 (comment)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no activity occurs in the next 5 days.