Phase 23.3: Clean up performance production boundaries

[jununfly]

This was generated by AI during triage.

Parent

• Phase 23: Optimization architecture cleanup #218
• Post-PRD optimization tracker for Rust indexing performance #165

What to build

Use the Phase 23 inventory to make narrow production-code cleanup changes in Rust indexing performance paths. The goal is clearer boundaries and more trustworthy diagnostics, not a performance win.

Production code may change only when the change preserves default behavior and makes performance/profile/reporting or retained diagnostic boundaries easier to reason about.

Acceptance criteria

• Use the inventory from Phase 23.2: Inventory performance experiment candidates #220 to choose cleanup targets.
• Keep cleanup scoped to Rust core profile/reporting structures, Rust core graph-write/finalization helpers, TypeScript Rust indexing orchestration profile handling, benchmark runner profile/artifact handling, retained diagnostic isolation, or dead candidate runtime removal.
• Do not change default user-visible indexing behavior.
• Do not change graph semantics or resolver semantics.
• Do not change SQLite schema.
• Do not change MCP behavior.
• Do not touch installer, packaging, release, status, or npm smoke paths.
• Do not use performance improvement as the pass condition.
• Retained diagnostic paths must be named or isolated clearly enough that they are not mistaken for default behavior.
• Dead candidates must be removed from runtime paths or explicitly justified as retained diagnostics.
• Run targeted TypeScript tests for touched orchestration/tooling.
• Run cargo test -p zcodegraph-core and cargo fmt -p zcodegraph-core --check if Rust core is touched.
• Run npm run build if TypeScript production paths are touched.

Blocked by

• Phase 23.2: Inventory performance experiment candidates #220

[jununfly]

This was generated by AI during triage.

Completed as part of Phase 23.

Summary:

• Evidence output now includes an explicit local-only Evidence Contract section.
• RSS unavailable reasons are now surfaced in generated comparison output.
• Performance experiment paths are inventoried as production path, retained diagnostic, or dead candidate.
• Production cleanup stayed on the benchmark/evidence boundary and did not change default indexing behavior.
• Targeted smoke/profile artifacts were generated from existing Phase 22 evidence; no full VS Code sparse scoreboard was run.
• Profile Rust parseExtractionMs before next optimization #224 was created as the next Post-PRD optimization tracker for Rust indexing performance #165 step for parseExtractionMs profiling.

Artifacts:

• docs/benchmarks/2026-06-18-rust-indexing-core-phase-23-experiment-inventory.md
• docs/benchmarks/2026-06-18-rust-indexing-core-phase-23-targeted-evidence-smoke-comparison.md
• docs/benchmarks/2026-06-18-rust-indexing-core-phase-23-targeted-evidence-smoke-decision-draft.md
• docs/benchmarks/2026-06-18-rust-indexing-core-phase-23-closeout-decision.md

Validation:

• npx vitest run __tests__/rust-indexing-evidence.test.ts
• npx vitest run __tests__/rust-indexing-evidence.test.ts __tests__/rust-indexing-experiment.test.ts
• npm run build

#165 remains open. Rust default rollout readiness is not claimed.