refactor: improve basic popup view structure and fix issues#624
Merged
Conversation
resolve popup open size adaptation resolve height and safe area adaptation avoid some unpleasant height changes and bounces
There is currently no effective way to detect visionOS in Apple Vision (Designed for iPad) mode. So it can only always be treated as ios to handle any surprises. setBadgeText `null` value tested working on Safari 15.6.1 (macOS 12.6).
ACTCD
force-pushed
the
fix/popup_size_and_basic_refactor
branch
from
a1ec620 to
8d9b7a2
Compare
quoid
approved these changes
Feb 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #621
Using a fixed width and height popup on macOS
Using no fixed height popup on iOS
ipados_rec.mp4
visionos_rec.mp4
This PR is just a basic refactoring and fix for the issues at hand.
More detailed adjustments will be made in future popup reconstruction.